-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BFT] model.Proposal
refactoring
#6526
Conversation
…otstuff proposal. Updated SafetyRules interface and implementation
…/6517-proposal-refactoring
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6526 +/- ##
==========================================
+ Coverage 41.28% 41.45% +0.17%
==========================================
Files 2050 2022 -28
Lines 182574 181034 -1540
==========================================
- Hits 75375 75049 -326
+ Misses 100870 99711 -1159
+ Partials 6329 6274 -55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Jordan Schalm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool. Thanks for the cleanup. Mostly minor comments regarding documentation.
consensus/hotstuff/votecollector/combined_vote_processor_v3_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Hentschel <[email protected]>
Co-authored-by: Alexander Hentschel <[email protected]>
…st.go Co-authored-by: Alexander Hentschel <[email protected]>
…onflow/flow-go into yurii/6517-proposal-refactoring
#6517
Context
This PR implements refactoring of
model.Proposal
, all details are in attached issue. This PR very closes follows proposed solution.